Skip to content

deprecate clear sky default in modelchain #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 14, 2019
Merged

deprecate clear sky default in modelchain #710

merged 5 commits into from
May 14, 2019

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented May 6, 2019 •
edited
Loading

  • Closes Deprecate clear sky fallback option from ModelChain.prepare_inputs and run_model #707
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

Brief description of the problem and proposed solution (if not already fully described in the issue linked to above):

@wholmgren wholmgren added the api label May 6, 2019
@wholmgren wholmgren added this to the 0.6.2 milestone May 6, 2019
@wholmgren
Copy link
Member Author

Appveyor failures are unrelated.

@wholmgren wholmgren requested a review from cwhanse May 13, 2019 19:55
cwhanse
cwhanse reviewed May 14, 2019
View reviewed changes
docs/sphinx/source/introexamples.rst Outdated
the ModelChain defaults to the `haydavies` model. In this example,
ModelChain infers the DC power model from the module provided by
examining the parameters defined for module.
necessary input data with modeled data. For example, no air temperature
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

necessary input with modeled data.

cwhanse
cwhanse reviewed May 14, 2019
View reviewed changes
docs/sphinx/source/introexamples.rst Outdated
transposition model is specified (keyword argument `transposition` for
ModelChain) so the ModelChain defaults to the `haydavies` model. In this
example, ModelChain infers the DC power model from the module provided
by examining the parameters defined for module.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defined for the module

@wholmgren wholmgren merged commit 252c1b2 into pvlib:master May 14, 2019
@wholmgren wholmgren deleted the mccsdep branch May 14, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhanse cwhanse cwhanse approved these changes

Assignees
No one assigned
Labels
api
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.

Deprecate clear sky fallback option from ModelChain.prepare_inputs and run_model
2 participants
@wholmgren @cwhanse