Skip to content

compatibility for cftime==1.1 #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2020
Merged

compatibility for cftime==1.1 #900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35c2bff
compat for cftime 1.1
wholmgren Feb 21, 2020
4d1b3d1
unused import
wholmgren Feb 21, 2020
4061e92
whats new
wholmgren Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/sphinx/source/whatsnew/v0.7.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ Bug fixes
`0.7.0 what's new <https://pvlib-python.readthedocs.io/en/stable/whatsnew.html#v0-7-0-december-18-2019>`_
entries about changes to ``PVSystem.pvwatts_ac``. Delete unreleased
0.6.4 what's new file. (:issue:`898`)
* Compatibility with cftime 1.1. (:issue:`895`)

Documentation
~~~~~~~~~~~~~
Expand Down
4 changes: 2 additions & 2 deletions pvlib/forecast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
The 'forecast' module contains class definitions for
retreiving forecasted data from UNIDATA Thredd servers.
'''
import datetime
from netCDF4 import num2date
import numpy as np
import pandas as pd
Expand Down Expand Up @@ -406,7 +405,8 @@ def set_time(self, time):
-------
pandas.DatetimeIndex
'''
times = num2date(time[:].squeeze(), time.units)
times = num2date(time[:].squeeze(), time.units,
only_use_cftime_datetimes=False)
self.time = pd.DatetimeIndex(pd.Series(times), tz=self.location.tz)

def cloud_cover_to_ghi_linear(self, cloud_cover, ghi_clear, offset=35,
Expand Down