Skip to content

BLD: build docs on Azure Pipelines #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Feb 26, 2020
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -194,3 +194,19 @@ jobs:

- script: python setup.py sdist
displayName: 'Build sdist'


- job: DocsTest
pool:
vmImage: 'ubuntu-16.04'
steps:
- task: UsePythonVersion@0
inputs:
versionSpec: '3.8'
- script: |
pip install -e .[all]
displayName: Replicate readthedocs CI environment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install pvlib for doc build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is necessary to run the sphinx-gallery examples at least. I was inspired by xarray's Azure config and this is also a step that xarray uses as well.

Based on the readthedocs.yml file, isn't this at least part of how ReadTheDocs builds our documentation for us? In our readthedocs.yml file it states that the extra_requirements are listed as -all and based on The ReadTheDocs documentation that is what is installed during their build of our docs. I'm inexperienced with ReadTheDocs so please let me know if I am missing something.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we're on the same page here. My comment should have been a suggestion like

    displayName: Install pvlib[all] for doc build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that better, thanks for the recommendation.

- script: |
cd docs/sphinx/
sphinx-build -j auto -b html -d _build/doctrees source build
displayName: Build HTML docs
2 changes: 2 additions & 0 deletions docs/sphinx/source/whatsnew/v0.7.2.rst
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,14 @@ Bug fixes
0.6.4 what's new file. (:issue:`898`)
* Compatibility with cftime 1.1. (:issue:`895`)
* Add Python3.8 to Azure Pipelines CI (:issue:`903`)(:pull:`904`)
* Add documentation build test to Azure Pipelines CI (:pull:`909`)
* Minor implemention changes to avoid runtime and deprecation warnings in
:py:func:`~pvlib.clearsky.detect_clearsky`,
:py:func:`~pvlib.iam.martin_ruiz_diffuse`,
:py:func:`~pvlib.losses.soiling_hsu`,
and various test functions.


Documentation
~~~~~~~~~~~~~
* Add NumFOCUS affiliation to Sphinx documentation (:pull:`862`)
Expand Down