Update tutorial notebooks for compat with current pvlib #999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates entries todocs/sphinx/source/api.rst
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.Here is an updated set of notebooks. I'll echo @mikofski's suggestion to use nbdime to review the changes. If you clone this branch, you can spawn a handy visual diff between commits in the browser with
nbdiff-web 065e10c 97c6698 docs\tutorials\atmosphere.ipynb
I also made some other changes unrelated to pvlib compat -- semicolons to suppress matplotlib output text and such. I also removed the section in
tmy.ipynb
that called out to the RREDC website (see #996). Lastly, I made the notebooks work with the nbval pytest plugin (added comments like# NBVAL_SKIP
for cells that shouldn't be tested) -- runpytest --nbval docs\tutorials\atmosphere.ipynb
if you want to check it out.I am aware of two remaining issues, neither of which I have investigated yet. I would not be upset if someone else figures out what's going on with these before I do :)