Merged
Conversation
Member
Author
|
This change also required configuring the pyproject.toml file to recognize the package name space. |
echedey-ls
reviewed
Mar 17, 2025
Member
|
I miss CI testing both sdist and bdist get built correctly too, may I open a PR for that? |
Member
Author
@echedey-ls Please do! I'm trying to keep this repository up to date as a template on which to base new packages on. In fact, as an editor for JOSS, I often refer people to this rather simple package for good practices. |
Member
|
I don't see any issues here. I built the distribution files locally and they looked fine. I suggest merging this and then verifying that #64 still works as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recommended package structure is to follow the src/package folder structure, see reasoning here and here.
This has been discussed for the pvlib-python package: pvlib/pvlib-python#2403
This change only requires a few modifications to the pyproject.toml file.
@echedey-ls, @kandersolar I think it makes sense to test it out on this package as it's much simpler and will give us an idea of what needs to be changed.