Skip to content

update lyrics library #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pwittchen merged 2 commits into from
Dec 3, 2025
Merged

update lyrics library #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93667f0
update lyrics library.
PauloWgDev Dec 3, 2025
c55ba6f
update README, requirements and removed comment from spotifycli.py
PauloWgDev Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,12 @@ if you don't use any parameters, you'll enter the shell mode, where you'll be ab
solving problems
----------------

### lyricwikia
### lyriq

When, you're missing `lyricwikia` dependency, run the following command:
When, you're missing `lyriq` dependency, run the following command:

```
pip install lyricwikia
pip install lyriq
```

usage with tmux
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
autopep8
jeepney
lyricwikia
lyriq
pycodestyle
pylint
setuptools
Expand Down
20 changes: 11 additions & 9 deletions spotifycli/spotifycli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@
import textwrap
import datetime
from subprocess import Popen, PIPE
import logging
Copy link
Owner

@pwittchen pwittchen Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this import needed?

import lyriq

import lyricwikia
logging.getLogger("lyriq.lyriq").setLevel(logging.CRITICAL)
Copy link
Owner

@pwittchen pwittchen Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this call neded?

Copy link
Contributor Author

@PauloWgDev PauloWgDev Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without it the lyriq library will print a 404 error when it does not found the song specified on it's database. So to make the logging more clean i added that call.

Copy link
Owner

@pwittchen pwittchen Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok


from jeepney import DBusAddress, new_method_call
from jeepney.io.blocking import open_dbus_connection
Expand Down Expand Up @@ -229,14 +231,14 @@ def show_song_short():

def show_lyrics():
artist, title = get_song()
try:
lyrics = lyricwikia.get_all_lyrics(artist, title)
except lyricwikia.LyricsNotFound:
raise SpotifyCLIException(
'Lyrics not found or could not connect'
) from None
lyrics = ''.join(lyrics[0])
print(lyrics)
lyrics = lyriq.get_lyrics(title, artist)

if lyrics is None:
print(f"Lyrics for '{title}' by {artist} were not found.")
print("This could happen if the track is missing from the lyrics database or is unsupported.")
return

print(lyrics.plain_lyrics)


def show_artist():
Expand Down
Loading