Gracefully handle "diff too large" errors #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epeters3
changed the title
|
Admin commands cheatsheet:
|
epeters3
force-pushed
the
fix/handle-diff-too-large
branch
from
bacda95 to
5bf9036
Compare
epeters3
force-pushed
the
fix/handle-diff-too-large
branch
from
743e501 to
f723625
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
Member
|
Congratulations on a stellar first contrib to the repo 🎉 |
Contributor
Author
Thanks so much, and thanks for such a timely review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #590. This PR adds an error handler to the diff fetching methods, and will raise a
CannotGetDiffexception if the too_large GitHub API error is detected. The exception is caught and causes a warning message to be included in the coverage comment, explaining why diff coverage can't be computed.