OVB sensitivity - Cinelli and Hazlett(2020) #1099
Conversation
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 40 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@s3alfisc the only thing I did not add in (didn't know if it was too useful/would add bloat) are the default sensitivity plots that PySensemakr makes. But I can add them if you would like |
|
Could you add some defensive checks (plus tests in |
Probably makes sense to add them, but we can do it in a separate PR. Not sure if these are really widely used in practice. |
|
We should add an example on how to use the method to the quickstart notebook. Last - it would be great to write a "how to" notebook - what cam you do with the method, why is it needed, how does it work, maybe why the authors argue it is better than other methods (as e.g. Oster)? Maybe something like this, but even more to the point? Note that this can also be done in a later PR. |
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…nto ovb_sensitivity
- Add treatment parameter to SensitivityAnalysis.summary() method - Fix unbound plot_estimate variable in ovb_contour_plot for t-value sensitivity - Add 10 tests for contour and extreme plotting functions
I have added everything but this. I think I will add this in a separate PR. I can draft an issue for this once we finalize and merge this PR |
2 participants
Hi @s3alfisc,
Putting in a draft PR here for your eyes. Let me know if you have any feedback on the API setup.
Here's what's left (I'm on it):
Just wanted to see if you had any bigger API design level changes before I went down the rabbit hole and implemented everything