Close #1122 #1132
Close #1122 #1132
Conversation
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 44 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@s3alfisc Can we merge this small fix? 🙂 |
| self._X.drop(na_separation, axis=0, inplace=True) | ||
| self._fe.drop(na_separation, axis=0, inplace=True) | ||
| self._data.drop(na_separation, axis=0, inplace=True) | ||
| self._Y = self._Y.drop(na_separation, axis=0, inplace=False) |
There was a problem hiding this comment.
Why can't we do this in place? Would it not be better to just add an ignore flag? Not doing the operation in place is likely less efficient?
There was a problem hiding this comment.
Approved, only minor comment was this ⬆️
There was a problem hiding this comment.
The SettingWithCopyWarning indicates that the attributes are not properly set upstream. You're right that we should keep it inplace and fix the root cause (probably where they assigned for the first time). Will investigate
Few adjustments to avoid
FutureWarning: ChainedAssignmentErrorandSettingWithCopyWarning. Closes #1122