Fix numpy iterable import in _causal_analysis.py for numpy>2.0#945
Merged
kbattocchi merged 1 commit intopy-why:mainfrom Jan 27, 2025
Merged
Fix numpy iterable import in _causal_analysis.py for numpy>2.0#945kbattocchi merged 1 commit intopy-why:mainfrom
kbattocchi merged 1 commit intopy-why:mainfrom
Conversation
Contributor
Author
|
@kbattocchi it looks like one of the checks to build documentation is failing, preventing a merge: |
Collaborator
|
@imatiach-msft The documentation problem is unrelated to your change; I'm working on a fix and will merge it into your PR once it's in, and then will merge your PR as well, you don't need to do anything further. |
Signed-off-by: Ilya Matiach <ilmat@microsoft.com>
carl-offerfit
pushed a commit
to carl-offerfit/EconML
that referenced
this pull request
Mar 4, 2025
…y#945) Signed-off-by: Ilya Matiach <ilmat@microsoft.com> Signed-off-by: Carl Gold <carl@offerfit.ai>
carl-offerfit
pushed a commit
to carl-offerfit/EconML
that referenced
this pull request
Mar 6, 2025
…y#945) Signed-off-by: Ilya Matiach <ilmat@microsoft.com> Signed-off-by: Carl Gold <carl@offerfit.ai>
carl-offerfit
pushed a commit
to carl-offerfit/EconML
that referenced
this pull request
Mar 31, 2025
…y#945) Signed-off-by: Ilya Matiach <ilmat@microsoft.com> Signed-off-by: Carl Gold <carl@offerfit.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With new numpy 2.0 update the numpy.lib.function_base namespace has become private.
If you try to import it you get the error:
In econml this throws the exception:
The fix is to import the function from numpy directly, which is also backwards compatible.