Andrin's changes minus all the pickle files, plus Egor's ERUPT refactor #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 1andrin <[email protected]>
…d some files from experiments Signed-off-by: 1andrin <[email protected]> scoring (updated version frobenius norm) Signed-off-by: 1andrin <[email protected]> updates Signed-off-by: 1andrin <[email protected]> several updates to frobenius norm, policy risk, prob erupt and the new score bite Signed-off-by: 1andrin <[email protected]> cleaned notebooks folder Signed-off-by: 1andrin <[email protected]> linter issues Signed-off-by: 1andrin <[email protected]> delete old cluster version of scoring.py Signed-off-by: 1andrin <[email protected]> linter issues Signed-off-by: 1andrin <[email protected]> linter issues Signed-off-by: 1andrin <[email protected]> updates to prob erupt and fixes in bite (according to tests) Signed-off-by: 1andrin <[email protected]> fixing issues with weight computation in erupt Signed-off-by: 1andrin <[email protected]> linter Signed-off-by: 1andrin <[email protected]> fix rounding issues Signed-off-by: 1andrin <[email protected]> add and organize current results (plots) Signed-off-by: 1andrin <[email protected]> fix outstanding test on Andrin's branch Cleanup of ERUPT logic, ERUPT-specific tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As above. Another PR coming that will clean up the plotting and large file generation logic in Andrin's code, this one just nukes the *.pkl files that don't belong
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to causaltune?
Put an
xin the boxes that applyChecklist
setup.pyis an individual PR and not mixed with feature or bugfix PRs