Creating augmented suggester #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grace Sng <grace.sng75@gmail.com>
…sponding utils. Signed-off-by: Grace Sng <grace.sng75@gmail.com>
Signed-off-by: Grace Sng <grace.sng75@gmail.com>
Signed-off-by: Grace Sng <grace.sng75@gmail.com>
Signed-off-by: Grace Sng <grace.sng75@gmail.com>
Signed-off-by: Grace Sng <grace.sng75@gmail.com>
Signed-off-by: Grace Sng <108954669+grace-sng7@users.noreply.github.com>
Signed-off-by: Grace Sng <108954669+grace-sng7@users.noreply.github.com>
Signed-off-by: Grace Sng <grace.sng75@gmail.com>
Signed-off-by: Grace Sng <grace.sng75@gmail.com>
Signed-off-by: Grace Sng <grace.sng75@gmail.com>
amit-sharma
requested changes
Jun 2, 2025
Member
amit-sharma
left a comment
amit-sharma
left a comment
There was a problem hiding this comment.
thanks for the PR @grace-sng7 I've shared a few inline comments.
I also notice that the build is failing. I'm working on a fix and will update this PR.
… dependencies. Signed-off-by: Grace Sng <grace.sng75@gmail.com>
Collaborator
Author
|
Hi Dr. Sharma, thanks for the comments. I've added a few updates to the PR. |
amit-sharma
reviewed
Jun 9, 2025
Member
amit-sharma
left a comment
amit-sharma
left a comment
There was a problem hiding this comment.
thanks @grace-sng7 I just have one comment for the notebook.
Signed-off-by: Grace Sng <grace.sng75@gmail.com>
Signed-off-by: Grace Sng <grace.sng75@gmail.com>
Signed-off-by: Grace Sng <grace.sng75@gmail.com>
Signed-off-by: Grace Sng <grace.sng75@gmail.com>
Added onxruntime dependency
Signed-off-by: Grace Sng <grace.sng75@gmail.com>
onnxruntime dependency
Signed-off-by: Grace Sng <grace.sng75@gmail.com>
Removed onnxruntime-silicon
amit-sharma
approved these changes
Jun 28, 2025
Member
amit-sharma
left a comment
amit-sharma
left a comment
There was a problem hiding this comment.
thanks @grace-sng7 The new edits remove the installation errors. Merging. ..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.