Skip to content

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Jun 20, 2024

No description provided.

@lwasser lwasser marked this pull request as ready for review June 21, 2024 18:45
@lwasser lwasser requested a review from kierisi as a code owner June 21, 2024 18:45
@lwasser lwasser changed the title draft 1: pycon sprints [blog]: pycon sprints & how pyos leads sprints 2024 Jun 21, 2024
Copy link
Contributor

@kierisi kierisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a great post! made grammatical suggestions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this image! small grammatical notes for the text below the screenshot:

  • followup should be follow up
  • In this case should have a comma after it
  • Hatch should be capitalized

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! i used the template you've been using for social and just adapted it to a "tip" type of image.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit: the previous images use complete sentences as the bullet points, which I think adds clarity to the image. it would be helpful to have complete sentences here as well, instead of sentence fragments.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've fixed this on all 3 images.

@lwasser lwasser changed the title [blog]: pycon sprints & how pyos leads sprints 2024 feat(blog): pycon sprints & how pyos leads sprints 2024 Jul 25, 2024
Copy link
Member Author

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the feedback on this PR @kierisi i have incorporated it into the blog post and pushed up the changes! i'm going to merge now so i can link to this in my scipy blog!

@lwasser
Copy link
Member Author

lwasser commented Jul 25, 2024

i just pushed final edits from the review and updates to images. I will merge once CI is happy! Then i'll rebase #448 with this so i can cross link.

@lwasser lwasser added the feature:content New content, guide, or writing needed label Jul 25, 2024
@lwasser lwasser merged commit 0f63d9f into pyOpenSci:main Jul 25, 2024
4 checks passed
@lwasser lwasser deleted the blog-sprints branch July 25, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:content New content, guide, or writing needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants