-
Notifications
You must be signed in to change notification settings - Fork 71
feat(blog): pycon sprints & how pyos leads sprints 2024 #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a great post! made grammatical suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love this image! small grammatical notes for the text below the screenshot:
followup
should befollow up
In this case
should have a comma after itHatch
should be capitalized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! i used the template you've been using for social and just adapted it to a "tip" type of image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit: the previous images use complete sentences as the bullet points, which I think adds clarity to the image. it would be helpful to have complete sentences here as well, instead of sentence fragments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've fixed this on all 3 images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the feedback on this PR @kierisi i have incorporated it into the blog post and pushed up the changes! i'm going to merge now so i can link to this in my scipy blog!
Co-authored-by: Jesse Mostipak <[email protected]>
Co-authored-by: Jesse Mostipak <[email protected]>
i just pushed final edits from the review and updates to images. I will merge once CI is happy! Then i'll rebase #448 with this so i can cross link. |
No description provided.