Skip to content

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Jul 11, 2024

This PR adds an events section to our website so we can post events as we hold them and link to setup instructions as needed.

@lwasser lwasser requested a review from kierisi as a code owner July 11, 2024 02:40
@@ -10,7 +10,7 @@ header:
author_profile: false
---

## Recent pyOpenSci Posts!
## Recent pyOpenSci Posts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete exuberance (breaking change) <3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sneakers-the-rat best review comment ever.

Copy link
Contributor

@kierisi kierisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

---
layout: single
title: "Workshop: pyOpenSci @ SciPy 2024 -- Create Your First Python Package"
excerpt: "Python packaging can be tricky to navigate. pyOpenSci will lead a workshop on creating your first Python package at SciPy 2024. The goal of this workshop is to help scientists learn how to package and make code installable and shareable. Read on to learn more!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be in future tense if the event has already happened?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes good point. we should think about that. we will want to have these pages in the future up before an event but become a long lasting record of our activities too. i don't think we want to switch tenses post event. but what we can do it automate something to add a section to the page if the event already happened and list them that way too.

if you agree that might work we can then open an issue about that point so it's clear to users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense. I think if the idea is to have them up ahead of time, then leaving it in future tense makes sense. love the idea of having an automated section added to indicate the event has happened!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. so the plan is to put these events up before it is held. we are just behind because i literally needed to create an events page to be able to put things up. but we will be ahead for the upcoming fall festival!

comments: true
---

## Create Your First Python Package: Make Your Python Code Easier to Share and Use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving this as is, however we've traditionally used sentence case rather than all caps (previous discussion)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if we can set this up for Vale to catch that for me. if i have a took checking things i'll do a better job with these small but important consistency pieces. maybe we can ask Felipe in slack about it as he setup vale for us and it's been great for other things like capitalization.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would be great! I know I constantly have to go back and re-edit mine as well.

@lwasser lwasser force-pushed the scipy-workshop-2024 branch from 6d99460 to 56900ae Compare July 25, 2024 23:17
@lwasser
Copy link
Member Author

lwasser commented Jul 25, 2024

hey @kierisi i have created a really basic (not pretty) template here and i've added now the scipy and our online workshop to the events page. we can make it prettier later.

but thinking about the fall festival - what template should we use for events?

the pages will be put up BEFORE an event but then of course the language will be dated as it is a past event. that is ok as it's easy for me to create a section for upcoming vs past events once we have enough content.

we should come up with an events page template that we use to events are consistent. have a look at the build here and let me know what you think. i just copied language from the post on our first workshop which is not ideal. but i think a solid template will make creating these pages easier in the future.

@lwasser
Copy link
Member Author

lwasser commented Jul 25, 2024

@kierisi one other note - i believe that i captures all of the your work here: blog in this PR however i did this on the plane and it looks like i wasn't careful about brining over the commits from your other pr.

but all of the work is here. are you comfortable with closing the other pr - #427 in favor of this one without the commits themselves? again the work is captured. I think i just moved too quickly around scipy because i was running out of time. (and this never got to be publish prior to the event anyway)

@kierisi
Copy link
Contributor

kierisi commented Jul 26, 2024

this template works for me! I think as we do more events we'll be able to better evaluate what changes might be helpful to the template.

@kierisi
Copy link
Contributor

kierisi commented Jul 26, 2024

@kierisi one other note - i believe that i captures all of the your work here: blog in this PR however i did this on the plane and it looks like i wasn't careful about brining over the commits from your other pr.

but all of the work is here. are you comfortable with closing the other pr - #427 in favor of this one without the commits themselves? again the work is captured. I think i just moved too quickly around scipy because i was running out of time. (and this never got to be publish prior to the event anyway)

sounds good! just to clarify, I can close the PR and it's all good to go?

@lwasser lwasser force-pushed the scipy-workshop-2024 branch from 4885b29 to ba8fbf3 Compare July 30, 2024 21:36
@lwasser
Copy link
Member Author

lwasser commented Jul 31, 2024

sounds good! just to clarify, I can close the PR and it's all good to go?

yes! i think i closed it earlier today. but all of the work you did in that PR is here now! and i've made things prettier with the event cards. i'll add dates later this week and then i think we can merge once we have a date for the fall festival.

@lwasser
Copy link
Member Author

lwasser commented Jul 31, 2024

ok - @kierisi this is i think ready to go. there are some changes in how we handle events -- i've added an Yaml section that will allow us to populate event details and it will be automatically displayed in the events listing page.

We will likely need to adjust this over time to meet our needs

events: 
  start_date: 
  end_date:
  cost: 

For now, I will merge this PR. The events pages will need some work so i will open an asana task for you to

  1. fill out the fall festival page
  2. Review the past event pages and make sure there is enough information for now on both pages.
    A few screenshots of changes made in this pr are below. Hopefully i didn't break too many things with the style updates.
Screenshot 2024-07-31 at 4 01 18 PM Screenshot 2024-07-31 at 4 01 07 PM Screenshot 2024-07-31 at 4 00 58 PM

@lwasser lwasser merged commit b6d1a5a into pyOpenSci:main Jul 31, 2024
4 checks passed
@lwasser lwasser deleted the scipy-workshop-2024 branch July 31, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants