Skip to content

Conversation

willingc
Copy link
Collaborator

@willingc willingc commented Sep 6, 2024

Easy fix to add a div did not work. 😢

@willingc willingc added the DO-NOT-MERGE A caution that a PR is not ready to be merged label Sep 6, 2024
Copy link
Contributor

@kierisi kierisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks good to me! @lwasser has been handling all website updates, so I'll leave it to her to approve. thank you for getting this fix in!

@lwasser
Copy link
Member

lwasser commented Sep 10, 2024

hi there @willingc thank you as always for helping us!! I submitted a fix for this the other day. The quote is rendered using a css :after selector. I applied it to the quote itself, but what happens if there is a footer element (the author) and also longer text throws things off! The fix was to add a div below the footer and apply the selector there. Our styles are a mess because, for years, I was forced to overwrite styles. I started this "kitchen sink" blog post

https://www.pyopensci.org/docs/pyos-website/

that will help us track style updates and how they impact various pyos elements on the website. i'm hopeful this will help

this is a long-winded way of saying - I'm sorry you went through the effort of opening this pr, and I think this has been fixed. I am going to gently close this pr 💟

@lwasser lwasser closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO-NOT-MERGE A caution that a PR is not ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants