Skip to content

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Sep 9, 2024

This should close #479 the issue was that the styles weren't in place to properly scale for very narrow devices (ie <480px). This also fixes a few other grid issues.

the bigger issue that is causing a lot of these problems is that there are a lot of overrides in the css from when i was force updating the theme (before breaking away from it). I try to find someone to do an overhaul on the website to make these updates and responsive design in general easier!

for now, i'm starting the process by cleaning up as we update things.

@lwasser lwasser requested a review from kierisi as a code owner September 9, 2024 00:19
{% if include.author %}<strong>~{{ include.author }}{% endif %}</strong>{%
if include.event %}, <em>{{ include.event }}</em>{% endif %}
</footer>
<div class="end"></div>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using an :after element for the quotes. this adds a new div below the footer (which is the quote author) that after is applied to. This makes it easier to align the close quote with the actual text.

### Figure -- align right

And now we're going to shift things to the **right align**. Again, there should be plenty of room above, below, and to the left of the image. Just look at him there --- Hey guy! Way to rock that right side. I don't care what the left aligned image says, you look great. Don't let anyone else tell you differently.
Below is a right aligned image
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates to the "kitchen sink" blogpost to test new styles before they go live.

}
}

@include breakpoint('max-width: #$mobile') {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will go back and look at this more closely. i'm still fighting with mixin include statements

}

/* Notice elements with figures */
.notice {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a lot of styles that should belong in a single scss sheet that are in blanket pyos- scss files (from before we broke out from the theme). we will need to slowly combine and reorganize things to make the code easier to maintain.

}


.feature__item--center .archive__item-body, .archive__item-body {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example of a element that should go in a different style sheet vs the page sheet.

.feature__item {
width: 95%!important;
}
.cards {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this belongs in pyos-cards -- again this is the problem! but it will take a good bit of time to clean up!

kierisi
kierisi previously approved these changes Sep 9, 2024
Copy link
Contributor

@kierisi kierisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks good and renders correctly for me. let me know if there's any additional feedback that would be helpful!

@lwasser lwasser merged commit 61bf042 into pyOpenSci:main Sep 9, 2024
4 checks passed
@lwasser lwasser deleted the fix-styles branch September 9, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: oversized quotes on blog obscure text on mobile and desktop

2 participants