Use actual DOI if available

[pllim]

Noticed this while working on #520 and it bothered me overnight.

[pllim]

One of the failures is unrelated:

• Website is down phenopype/phenopype#5

[lwasser]

i wonder if this could be a lychee issue - i see this at the top of the issue. which is also odd. a bunch of warnings. because these links i thikjnk work

Run /home/runner/work/_actions/lycheeverse/lychee-action/v2.1.0/entrypoint.sh
/home/runner/work/_actions/lycheeverse/lychee-action/v2.1.0/entrypoint.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
GITHUB_TOKEN: ***
INPUT_TOKEN: ***
INPUT_ARGS: --verbose --no-progress _site/*.html
INPUT_DEBUG: false
INPUT_FAIL: true
INPUT_FAILIFEMPTY: true
INPUT_FORMAT: markdown
INPUT_JOBSUMMARY: true
INPUT_OUTPUT: lychee/out.md
[WARN ] Error creating request: InvalidPathToUri("/feed.xml")
[WARN ] Error creating request: InvalidPathToUri("/assets/css/main.css")
[WARN ] Error creating request: InvalidPathToUri("/images/favicon.ico")
[WARN ] Error creating request: InvalidPathToUri("/feed.xml")
[WARN ] Error creating request: InvalidPathToUri("/assets/css/main.css")
[WARN ] Error creating request: InvalidPathToUri("/images/favicon.ico")
[WARN ] Error creating request: InvalidPathToUri("/")
[WARN ] Error creating request: InvalidPathToUri("/images/logo.png")
[WARN ] Error creating request: InvalidPathToUri("/feed.xml")
[WARN ] Error creating request: InvalidPathToUri("/assets/css/main.css")
[WARN ] Error creating request: InvalidPathToUri("/images/favicon.ico")
[WARN ] Error creating request: InvalidPathToUri("/about-peer-review/index.html")
[WARN ] Error creating request: InvalidPathToUri("/partners.html")
[WARN ] Error creating request: InvalidPathToUri("/python-packages.html")
[WARN ] Error creating request: InvalidPathToUri("/")

Ok i see aother issue - i'm going to open a separate issue about this. the JOSS-approved link to sourmash (and this link ONLY seem to exist for sourmash), is definitely broken. it's trying to behave like a relative link when it should be an absolute link. This is a website code issue that we can fix to begin to trouble shoot.

[lwasser]

#524

trying this - at a minimum it's fixing an actual broken link 😆 but if this works then we need to make sure that joss published packages have the badge in our issue template before the issue is closed.

[pllim]

I don't grok #524 . Does this mean I should close this PR without merge?

[lwasser]

@pllim, Yes, I suggest that we close this, and I'll do that now. @banesullivan is working on updating pyosMeta to parse these urls uniformly. if we merge this it will fix things temporarily but then will get overwritten once the next cron job runs!

At least through our tries here, we figured out the issue! Fixing it at the source is the best solution :0