Skip to content

Conversation

rmj3197
Copy link
Contributor

@rmj3197 rmj3197 commented Jan 17, 2025

This is the blog post for QuadratiK py-os accepted package ref - pyOpenSci/software-submission#180

@rmj3197 rmj3197 requested a review from lwasser as a code owner January 17, 2025 11:23
@rmj3197
Copy link
Contributor Author

rmj3197 commented Jan 17, 2025

pre-commit.ci autofix

@lwasser
Copy link
Member

lwasser commented Jan 18, 2025

hey, @rmj3197, thank you so much for this!! We are excited to promote Quadratik for you!! I'll put it in my review queue and will get back to you. 🚀 Have an awesome weekend!!

@lwasser
Copy link
Member

lwasser commented Feb 6, 2025

@all-contributors please add @rmj3197 for code, review

@allcontributors
Copy link
Contributor

@lwasser

I've put up a pull request to add @rmj3197! 🎉

@lwasser
Copy link
Member

lwasser commented Feb 6, 2025

@rmj3197 I should be able to merge this today and then i'll push it out on social 🚀
were you already invited to our slack community? if you are interested in that please share an email with me or contact me directly leah at pyopensci.org.

@rmj3197
Copy link
Contributor Author

rmj3197 commented Feb 6, 2025

Hi @lwasser, thank you very much for the update and the review. I am interested in joining the slack, you can send me an invitation at [rmj.3197 at gmail.com]. Thank you very much for your help!

@lwasser
Copy link
Member

lwasser commented Feb 6, 2025

ok this is building well now and all looks great! thank you for the PR. i'll merge now and push out on social.

lwasser
lwasser previously approved these changes Feb 6, 2025
@lwasser
Copy link
Member

lwasser commented Feb 6, 2025

Ok I spoke too soon. I believe there are two images that are backups to webp images that don't exist.

Checking 305 external links
For the Images check, the following failures were found:

* At _site/blog/quadratik.html:783:

  internal image /images/quadratik/dog-cat-segmented.png does not exist

* At _site/blog/quadratik.html:795:

  internal image /images/quadratik/validation-dog-cat.png does not exist

@rmj3197 please see here: https://github.com/pyOpenSci/pyopensci.github.io/actions/runs/13184899460/job/36804641398?pr=551#step:8:13

can you please add these images to the pr and let's see if that makes CI happy? please ping me again here when that is complete and i'll have a look.

@rmj3197
Copy link
Contributor Author

rmj3197 commented Feb 6, 2025

Hi @lwasser , I added the .png images. Sorry for the trouble. Hopefully it works.

Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the visuals. Thanks for submitting.

@lwasser
Copy link
Member

lwasser commented Feb 6, 2025

@rmj3197 no trouble at all!! thank you - CI is now happy. And i second @willingc comment!! the blog post looks great and all of the images really add to that! thank you for your effort in writing this!! merging now

@lwasser lwasser merged commit 8dbcd8b into pyOpenSci:main Feb 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants