Skip to content

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Mar 15, 2025

No description provided.

tkoyama010
tkoyama010 previously approved these changes Mar 16, 2025
Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lwasser
Copy link
Member Author

lwasser commented Mar 18, 2025

thank you, @tkoyama010. Please note if you saw a "lesser dismissed your review," it wasn't intentional. I saw that somewhere and wondered if it is because I did a force push after your review. 🤷🏻‍♀️ anyway I'll make sure to fix the ci stuff I broke with the force push and then we can merge 🚀

@lwasser lwasser marked this pull request as draft March 18, 2025 00:48
@lwasser lwasser marked this pull request as ready for review March 18, 2025 15:04
@lwasser
Copy link
Member Author

lwasser commented Mar 18, 2025

Ok, merging this as it's too huge not to at this point. still more work to be done via smaller prs.

@lwasser lwasser merged commit 7737a96 into pyOpenSci:main Mar 18, 2025
4 checks passed
@lwasser lwasser deleted the fix-fonts branch March 18, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants