Skip to content

Conversation

banesullivan
Copy link
Contributor

This opts into automatically fixing PRs with pre-commit CI and removes pre-commit/action from the GitHub Actions workflows

  • The pre-commit/action GitHub Action is in maintenance only mode and they recommend swithing to pre-commit CI
  • We previously used pre-commit/action to automatically reformat the YAML data files generated during the automated data update jobs.
  • This PR will instead have those jobs automatically update the data, then pre-commit will automatically fix the formatting as a second commit.

This will remove the confusing error annotation we're seeing on the data update CI jobs since the pre-commit check technically fails since it reformats the YAML data files after they are generated

Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @banesullivan. Good catch on the action being in maintenance only mode.

I have mixed feelings about autofix for larger projects but for the size of pyOpenSci it is fine. We can always revert if it becomes to chatty.

@willingc willingc merged commit 482b0f9 into pyOpenSci:main Mar 30, 2025
5 checks passed
@banesullivan
Copy link
Contributor Author

I agree, I also typically don't like the auto fix, but I think these projects are a good fit for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants