Skip to content

Fix contributor count pagination - add per_page=100 to contributors A… #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix contributor count pagination - add per_page=100 to contributors A… #292

wants to merge 1 commit into from

Conversation

stevenrayhinojosa-gmail-com
Copy link

API call

  • Resolves issue where contributor counts were capped at 30
  • Now fetches all contributors using 100 pagination
  • SunPy should show 239 contributors instead of 30
  • We may need to debug at lines 236 -246 debug on github_api.py

Fix contributor count pagination - add per_page=100 to contributors A…
cfafa50 
…PI call

- Resolves issue where contributor counts were capped at 30
- Now fetches all contributors using proper pagination
- SunPy should show 239 contributors instead of 30
@lwasser
Copy link
Member

lwasser commented Jul 22, 2025

@all-contributors please add @stevenrayhinojosa-gmail-com for code, review

Steven thank you for this! i think we can merge as it will enhance our contributor numbers but this bug still exists (i think) because i think we need to ensure the data from the api are paginated when contribs are over 100!

@allcontributors allcontributors bot mentioned this pull request Jul 22, 2025
Merged
@allcontributors AllContributors
Copy link
Contributor

@lwasser

I've put up a pull request to add @stevenrayhinojosa-gmail-com! 🎉

@lwasser lwasser mentioned this pull request Jul 22, 2025
Open
@lwasser
Copy link
Member

lwasser commented Jul 22, 2025

Oops - this is throwing a different error. we can't merge yet until we troubleshoot.

lwasser
lwasser requested changes Jul 22, 2025
View reviewed changes
Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unapproving while we troubleshoot the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwasser lwasser lwasser requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
pyOpenSci sprint events 2023-2025
Status: scipy25
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenrayhinojosa-gmail-com @lwasser