schema: reviewers can be empty now + parsing: handle bold/italics formatting #310

mathematicalmichael · 2025-10-08T16:25:32Z

Our contributor build for the website is broken because we have a package that was accepted via our new JOSS fast track process! (see the new policy pr here https://github.com/pyOpenSci/software-peer-review/pull/342/files)

This change updates reviewers to accept None and defaults to it instead of an empty list.

+also includes bugfix for bold/italics formatting in values of the templated issue, introduced by the same submission

Update get_contributor_data method to return None when no models are found.

return None instead of trying to instantiate a ReviewUser

ucodery

This looks good

lwasser · 2025-10-08T19:56:43Z

👋🏻 Hello there. I need to allow tests to run on all incoming pr's. it looks like the tests are still failing here. Let me fix the settings for the repo to ensure tests always run.

Refactor user model parsing to handle empty lists.

mathematicalmichael · 2025-10-09T17:47:56Z

workflow for ae652fb failed because of an unrelated connection error. I checked the URL manually and it worked, so I assume this was just a temporary blip.

early return when we're missing a ReviewUser / fail to validate the PersonModel (skip behavior to align with the existing log statement)

codecov · 2025-10-09T18:10:14Z

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.05%. Comparing base (8a7f61e) to head (313f844).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
src/pyosmeta/parse_issues.py	33.33%	1 Missing and 1 partial ⚠️
src/pyosmeta/utils_parse.py	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
- Coverage   79.47%   79.05%   -0.42%     
==========================================
  Files          12       12              
  Lines         760      764       +4     
  Branches       98      100       +2     
==========================================
  Hits          604      604              
- Misses        144      146       +2     
- Partials       12       14       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

there's a contributor that's being processed with * in their name. stripping this character should allow them to be processed as a PersonModel (in theory)

erik-whiting

Nice fix to the spec

Strip markdown formatting from returned value.

mathematicalmichael · 2025-10-09T20:25:21Z

it seems that pyOpenSci/software-submission#254 broke things in two ways:

first, this PR was meant to fix the empty reviewers, which was fixed with some modeling changes
later, I noticed that the ** formatting in the markdown of the linked issue was causing a failure for fetch of github metrics. this was due to the lack of handling the issue author used, which was fixed with some processing changes.

mathematicalmichael · 2025-10-09T20:31:18Z

src/pyosmeta/utils_clean.py

    """Remove unwanted characters from a name."""

-    unwanted = ["(", ")", "@"]
+    unwanted = ["(", ")", "@", "*"]


arguably, not needed anymore since this is stripped during parsing time. it did help earlier but only for the username, not the package name.

Suggested change

unwanted = ["(", ")", "@", "*"]

unwanted = ["(", ")", "@"]

banesullivan

This looks good, nice fix @mathematicalmichael! Thanks for jumping on this!

Added details for version 1.7.6 including bug fix and feature.

mathematicalmichael added 3 commits October 8, 2025 10:24

Change reviewers field to be optional

b5fa826

Modify get_contributor_data return type to include None

f73cf0c

Update get_contributor_data method to return None when no models are found.

Add check for empty GitHub username and name

2972e45

return None instead of trying to instantiate a ReviewUser

ucodery approved these changes Oct 8, 2025

View reviewed changes

mathematicalmichael added 4 commits October 8, 2025 18:07

fix models checking logic

d12f6c5

debug: hatch run

04237a6

Merge branch 'pyOpenSci:main' into patch-1

ae652fb

go back to simpler handling of empty models

6a7b4d5

Refactor user model parsing to handle empty lists.

Fix error handling for new contributors in update_review_teams

61c41c1

early return when we're missing a ReviewUser / fail to validate the PersonModel (skip behavior to align with the existing log statement)

Add '*' to unwanted characters in clean_name function

6e98d53

there's a contributor that's being processed with * in their name. stripping this character should allow them to be processed as a PersonModel (in theory)

erik-whiting approved these changes Oct 9, 2025

View reviewed changes

Remove markdown formatting from issue value

e4c678e

Strip markdown formatting from returned value.

mathematicalmichael commented Oct 9, 2025

View reviewed changes

mathematicalmichael changed the title ~~Change reviewers field to be optional~~ schema: reviewers can be empty now + parsing: handle bold/italics formatting Oct 9, 2025

mathematicalmichael requested a review from erik-whiting October 9, 2025 20:32

banesullivan approved these changes Oct 9, 2025

View reviewed changes

Update CHANGELOG for version 1.7.6

313f844

Added details for version 1.7.6 including bug fix and feature.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

schema: reviewers can be empty now + parsing: handle bold/italics formatting #310

schema: reviewers can be empty now + parsing: handle bold/italics formatting #310

Uh oh!

mathematicalmichael commented Oct 8, 2025 •

edited

Loading

Uh oh!

ucodery left a comment

Uh oh!

lwasser commented Oct 8, 2025

Uh oh!

mathematicalmichael commented Oct 9, 2025

Uh oh!

codecov bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

erik-whiting left a comment

Uh oh!

mathematicalmichael commented Oct 9, 2025 •

edited

Loading

Uh oh!

mathematicalmichael Oct 9, 2025

Uh oh!

banesullivan left a comment

Uh oh!

Uh oh!

schema: reviewers can be empty now + parsing: handle bold/italics formatting #310

Are you sure you want to change the base?

schema: reviewers can be empty now + parsing: handle bold/italics formatting #310

Uh oh!

Conversation

mathematicalmichael commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ucodery left a comment

Choose a reason for hiding this comment

Uh oh!

lwasser commented Oct 8, 2025

Uh oh!

mathematicalmichael commented Oct 9, 2025

Uh oh!

codecov bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

erik-whiting left a comment

Choose a reason for hiding this comment

Uh oh!

mathematicalmichael commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mathematicalmichael Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

banesullivan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mathematicalmichael commented Oct 8, 2025 •

edited

Loading

codecov bot commented Oct 9, 2025 •

edited

Loading

mathematicalmichael commented Oct 9, 2025 •

edited

Loading