Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pyosmeta/models/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ class ReviewModel(BaseModel):
categories: Optional[list[str]] = None
editor: ReviewUser | list[ReviewUser] | None = None
eic: ReviewUser | list[ReviewUser] | None = None
reviewers: list[ReviewUser] = Field(default_factory=list)
reviewers: list[ReviewUser] | None = None
archive: str | None = None
version_accepted: str | None = None
date_accepted: str | None = Field(
Expand Down
4 changes: 3 additions & 1 deletion src/pyosmeta/parse_issues.py
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ def parse_issues(

def get_contributor_data(
self, line: str
) -> Union[ReviewUser, List[ReviewUser]]:
) -> Union[ReviewUser, List[ReviewUser], None]:
"""Parse names for various review roles from issue metadata.

Parameters
Expand All @@ -360,6 +360,8 @@ def get_contributor_data(
models = [model for model in models if model is not None]
if len(models) == 1:
models = models[0]
if len(models) == 0:
return None
return models

# TODO: This now returns a dict of owner:repo_name to support graphql
Expand Down
3 changes: 2 additions & 1 deletion src/pyosmeta/utils_parse.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,6 @@ def parse_user_names(username: str) -> ReviewUser | None:
"github_username": clean_name(names[0]),
"name": "",
}

if (parsed["github_username"] == "") and (parsed["name"] == ""):
return None
return ReviewUser(**parsed)
Loading