Skip to content

Conversation

tkoyama010
Copy link
Member

This PR updates the Japanese locale files with the newest version of the English guide.
See #439 and #444

@tkoyama010
Copy link
Member Author

pre-commit.ci autofix

@tkoyama010 tkoyama010 marked this pull request as ready for review February 17, 2025 23:00
@tkoyama010 tkoyama010 requested a review from flpm February 19, 2025 22:34
@flpm
Copy link
Member

flpm commented Mar 15, 2025

Oops, looks like I missed the request for review. I just build the docs in Japanese and everything seems fine, but there were multiple warnings like these one:

/home/felipe/github/pyOpenSci/python-package-guide/.nox/docs-test/lib/python3.10/site-packages/sphinxext/opengraph/socialcards.py:168: UserWarning: Glyph 22259 (\N{CJK UNIFIED IDEOGRAPH-56F3}) missing from font(s) Roboto Flex.

A quick search on Google shows me that this glyph is https://unicodeplus.com/U+56f3 and it means illustration, so maybe it's a caption for a figure somewhere?

I wonder if this means that some characters may not appear in the Japanese site because of the Robot Flex font. Searching in the folder for this character inside the build folder, only give hits in the binary .doctree files. So I will merge for now.

Copy link
Member

@flpm flpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the warning above, but I don't think it is related to the translation itself.

@flpm
Copy link
Member

flpm commented Mar 15, 2025

CI failures are because of link checker, the links seem to exist, so I will merge.

@flpm flpm merged commit ff3f9cd into main Mar 15, 2025
3 of 4 checks passed
@flpm flpm deleted the update-japanese-translation-files branch March 15, 2025 17:23
@flpm flpm added the lang-JA label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants