-
Notifications
You must be signed in to change notification settings - Fork 73
fix: bad links #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: bad links #487
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,10 +36,10 @@ First, fork the guide repository into your personal GitHub account and clone the | |
To create a virtual environment and install the development dependencies for the guide, run the following commands: | ||
|
||
```shell | ||
$ cd ./python-package-guide | ||
$ python -m venv .venv | ||
$ source .venv/bin/activate | ||
$ pip install .[dev] | ||
cd ./python-package-guide | ||
python -m venv .venv | ||
source .venv/bin/activate | ||
pip install .[dev] | ||
lwasser marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
``` | ||
|
||
TODO: This section needs more work or to be replaced with a reference to the CONTRIBUTING guide. | ||
|
@@ -75,7 +75,7 @@ The translation files contain the original English text and a space for you to e | |
You can do this by running the following command, replacing LANG by the language code you plan to work on (e.g., `es` for Spanish): | ||
|
||
```shell | ||
$ nox -s update-language -- LANG | ||
nox -s update-language -- LANG | ||
lwasser marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
``` | ||
|
||
This command will create the translation files if they don't exist yet, or update them with the latest changes if they already exist. | ||
|
@@ -287,7 +287,7 @@ If a language is ready to go live, the maintainers will add the language code to | |
|
||
When the guide is built for release in CI, Sphinx will also generate the translated versions of the guide for the languages in the `RELEASE_LANGUAGES` list. | ||
|
||
Translations are released in the same way as the English version of the guide, and the translated versions will be available in folders named after the language code. For example, the Spanish translation will be available in [https://www.pyopensci.org/python-package-guide/es/](https://www.pyopensci.org/python-package-guide/es/). | ||
Translations are released in the same way as the English version of the guide, and the translated versions will be available in folders named after the language code. For example, the Spanish translation will be available at: `https://www.pyopensci.org/python-package-guide/es/` when it is published online. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This link is broken because spanish isn't published yet. |
||
|
||
## Frequently Asked Questions (FAQ) | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops that is weird - i didn't actually make that change locally.