Skip to content

Conversation

hfactor13
Copy link
Contributor

@hfactor13 hfactor13 commented Jul 13, 2025

I updated the CSS file so that the button is more readable. Here's the issue number for reference.
fix #533

@tkoyama010 tkoyama010 requested a review from Copilot July 13, 2025 09:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the primary theme color for better readability in light mode and adjusts the hover label styling in the translation graph.

  • Lightens the --pyos-color-primary CSS variable for improved button contrast.
  • Sets hover label background to the page’s body background and fixes hover label font color.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
_static/pyos.css Updated --pyos-color-primary to a lighter shade
_ext/translation_graph.py Added hoverlabel_bgcolor and hoverlabel_font_color settings

@tkoyama010
Copy link
Member

LGTM
スクリーンショット 2025-07-17 5 39 13

@tkoyama010 tkoyama010 merged commit 2677c9b into pyOpenSci:main Jul 16, 2025
4 checks passed
@tkoyama010
Copy link
Member

@all-contributors please add @hfactor13 for code and design

Copy link
Contributor

@tkoyama010

I've put up a pull request to add @hfactor13! 🎉

@hfactor13 hfactor13 deleted the light-mode-button-fix branch July 16, 2025 20:46
@lwasser lwasser moved this from scipy-24 to scipy25 in pyOpenSci sprint events 2023-2025 Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Bug: Light Mode - buttons aren't accessible

3 participants