-
Notifications
You must be signed in to change notification settings - Fork 11
Implements switchable color vision deficiency simulation to the docs #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adds material icons for the ui all cmaps now render all 4 selectable cvd types for the docs, making this take longer/be bigger.
|
I found currently the plots only show up if you refresh the page, so i'll still look into that 😅 |
* wip * remove no sync * ci: update Python setup action and pre-commit hook versions; fix typo in ColorStops class * fix rtd * ignore w004 * upd
pyapp-kit#102) Bumps [pyvista/setup-headless-display-action](https://github.com/pyvista/setup-headless-display-action) from 3 to 4. - [Release notes](https://github.com/pyvista/setup-headless-display-action/releases) - [Commits](pyvista/setup-headless-display-action@v3...v4) --- updated-dependencies: - dependency-name: pyvista/setup-headless-display-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 95.51% 95.49% -0.03%
==========================================
Files 166 166
Lines 2165 2175 +10
==========================================
+ Hits 2068 2077 +9
- Misses 97 98 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think this is freaking awesome. Thank you! I'm happy to hit merge as is. It's very nicely implemented too.
|
|
pre-commit issues are on main too. Don't worry about them. Let me know if you want to do anything else in this PR if if it's ready for merge |
|
This is ready to merge i think! I couldn't very quickly find a way to implement the question icon. This would indeed probably be the best way to implement this - other option is to just add some text to the For the sine-ramp it makes sense yes, and i indeed didnt touch it because it seemed like too much hassle, and because i personally also mostly care about the perceptual lightness 😊 |
|
Absolutely. Thanks again for your efforts on this! Much appreciated, great addition. |
|
Wow, seriously cool. Nice work @oanegros ! |

As discussed in #96
This implementation makes the docs require all 4 cvd type datasets implemented (normal/full vision, protan, deutan and tritan at 100% severity), and converts colors before calculating perceptual lightness, RGB/HSV values.
Colors are clipped to correct RGB codes (no negative or >255 values allowed), which allow for easy checking of linearity and other features of colormaps for the different cvd types.
I added a radio button with icons at the top to try to fit within the style the docs had until now visually.
closes #96