Skip to content

Conversation

@tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Apr 10, 2025

fixes #98 (which was caused by a faulty check for whether a name was an alias during building of the docs). The workaround is to prevent any keys with dashes in the record.json files. This is somewhat hacky, but I added a warning for now which will fail tests if another dashed name is added in the future. If we really need dashed keys in record.json, we can fix it later

@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@5e1fb5a). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage        ?   96.36%           
=======================================
  Files           ?      166           
  Lines           ?     2147           
  Branches        ?        0           
=======================================
  Hits            ?     2069           
  Misses          ?       78           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 enabled auto-merge (squash) April 10, 2025 17:45
@tlambert03 tlambert03 merged commit f36acdf into pyapp-kit:main Apr 10, 2025
21 checks passed
@tlambert03 tlambert03 deleted the fix-docs branch April 10, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No document pages for colormaps with "-" in the name

1 participant