-
Notifications
You must be signed in to change notification settings - Fork 53
build: support python 3.14 #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
==========================================
+ Coverage 88.86% 89.27% +0.40%
==========================================
Files 40 40
Lines 4815 4820 +5
==========================================
+ Hits 4279 4303 +24
+ Misses 536 517 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
i had to sort of "cherry pick" OS/Qt/python versions here for some of the old qt versions (right here) in order to avoid segfaults. it's probably not super robust, but it's also outside of the scope of simply trying to support python 3.14. So I'm going with it. |
closes #720
The key fix here is the fix to
MagicParameter.__str__, to accomodate changes made toinspect.Parameter.__str__in python 3.14. The rest is just to get tests passing again for random Qt issues