refactor: update exception message#351
Merged
tlambert03 merged 3 commits intopyapp-kit:mainfrom Jan 27, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #351 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 2095 2115 +20
=========================================
+ Hits 2095 2115 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yet another update to how the emit loop error exception looks. with this PR it will now look something like this:
While emitting signal 'ndv.models._mapping.ValidatedEventedDict.value_changed', an error occurred in a callback: ValueError: Dimensions {0, 1, 2} do not exist. Expected one or more of ('time', 'lat', 'lon') --------------------------------------------------------------------------------------------- SIGNAL EMISSION: /Users/talley/dev/self/ndv/src/ndv/controllers/_array_viewer.py:302 in _on_view_current_index_changed self._data_model.display.current_index.update(self._view.current_index()) /Users/talley/dev/self/ndv/src/ndv/models/_mapping.py:187 in update self.value_changed.emit() # <-- SIGNAL WAS EMITTED HERE CALLBACK CHAIN: /Users/talley/dev/self/ndv/src/ndv/controllers/_array_viewer.py:275 in _on_model_current_index_changed ... 6 more frames ... /Users/talley/dev/self/ndv/.venv/lib/python3.12/site-packages/xarray/core/utils.py:802 in drop_dims_from_indexers raise ValueError( # <-- ERROR OCCURRED HERE Local variables: indexers = {1: slice(None, None, None), 2: slice(None, None, None), 0: ... dims = ('time', 'lat', 'lon') missing_dims = 'raise' invalid = {0, 1, 2}