Skip to content

refactor: update exception message#351

Merged
tlambert03 merged 3 commits intopyapp-kit:mainfrom
tlambert03:update-err-message
Jan 27, 2025
Merged

refactor: update exception message#351
tlambert03 merged 3 commits intopyapp-kit:mainfrom
tlambert03:update-err-message

Conversation

@tlambert03
Copy link
Member

yet another update to how the emit loop error exception looks. with this PR it will now look something like this:

While emitting signal 'ndv.models._mapping.ValidatedEventedDict.value_changed', an error occurred in a callback:

  ValueError: Dimensions {0, 1, 2} do not exist. Expected one or more of ('time', 'lat', 'lon')
  ---------------------------------------------------------------------------------------------

  SIGNAL EMISSION: 
    /Users/talley/dev/self/ndv/src/ndv/controllers/_array_viewer.py:302 in _on_view_current_index_changed
      self._data_model.display.current_index.update(self._view.current_index())
    /Users/talley/dev/self/ndv/src/ndv/models/_mapping.py:187 in update
      self.value_changed.emit()  # <-- SIGNAL WAS EMITTED HERE

  CALLBACK CHAIN:
    /Users/talley/dev/self/ndv/src/ndv/controllers/_array_viewer.py:275 in _on_model_current_index_changed
    ... 6 more frames ...
    /Users/talley/dev/self/ndv/.venv/lib/python3.12/site-packages/xarray/core/utils.py:802 in drop_dims_from_indexers
      raise ValueError(  # <-- ERROR OCCURRED HERE 

      Local variables:
            indexers = {1: slice(None, None, None), 2: slice(None, None, None), 0: ...
                dims = ('time', 'lat', 'lon')
        missing_dims = 'raise'
             invalid = {0, 1, 2}

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 26, 2025

CodSpeed Performance Report

Merging #351 will not alter performance

Comparing tlambert03:update-err-message (01270c8) with main (2179994)

Summary

✅ 67 untouched benchmarks

@codecov
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2179994) to head (01270c8).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #351   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         2095      2115   +20     
=========================================
+ Hits          2095      2115   +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 merged commit f1ca61a into pyapp-kit:main Jan 27, 2025
48 checks passed
@tlambert03 tlambert03 deleted the update-err-message branch January 27, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant