Skip to content

fix: use safer repr in warning#353

Merged
tlambert03 merged 3 commits intopyapp-kit:mainfrom
tlambert03:safe-repr
Jan 27, 2025
Merged

fix: use safer repr in warning#353
tlambert03 merged 3 commits intopyapp-kit:mainfrom
tlambert03:safe-repr

Conversation

@tlambert03
Copy link
Member

I found an edge case when trying to connect to a slot, where that slot itself had a recursion error in its __repr__ method, where the entire connection failed with a recursion error in what should have been a simple warning when the slot was not weak-refable. This PR uses object.__repr__(object) instead of repr(object), just in case the object in question in un-reprable

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 27, 2025

CodSpeed Performance Report

Merging #353 will not alter performance

Comparing tlambert03:safe-repr (8cd3233) with main (f1ca61a)

Summary

✅ 67 untouched benchmarks

@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f1ca61a) to head (8cd3233).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #353   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         2115      2116    +1     
=========================================
+ Hits          2115      2116    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 merged commit 0f6e607 into pyapp-kit:main Jan 27, 2025
47 of 48 checks passed
@tlambert03 tlambert03 deleted the safe-repr branch January 27, 2025 17:01
@tlambert03 tlambert03 added the bug Something isn't working label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

1 participant