Skip to content

fix: fix TypeError on range slider when min equals max #310

Merged
tlambert03 merged 1 commit intopyapp-kit:mainfrom
tlambert03:fix-307
Oct 13, 2025
Merged

fix: fix TypeError on range slider when min equals max #310
tlambert03 merged 1 commit intopyapp-kit:mainfrom
tlambert03:fix-307

Conversation

@tlambert03
Copy link
Member

fixes #307

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.40%. Comparing base (b11b511) to head (301d233).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
+ Coverage   86.38%   86.40%   +0.02%     
==========================================
  Files          49       49              
  Lines        3862     3862              
==========================================
+ Hits         3336     3337       +1     
+ Misses        526      525       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Czaki Czaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@tlambert03
Copy link
Member Author

Thanks for quick review @Czaki!

@tlambert03 tlambert03 merged commit 5335004 into pyapp-kit:main Oct 13, 2025
29 checks passed
@tlambert03 tlambert03 deleted the fix-307 branch October 13, 2025 17:09
@tlambert03 tlambert03 added the bug Something isn't working label Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

FloatRangeSlider throws TypeError when min is set to 99 but not 98

2 participants