Skip to content

Conversation

@tlambert03
Copy link
Member

fixes #318

something happened in pyside 6.10 that prevents standard mocking patterns (which we were using in our tests).

This attempts to workaround the regression with a different pattern

@tlambert03 tlambert03 changed the title tests: fix pyside6 segfault tests: fix pyside6 segfault in cmap combo tests Dec 27, 2025
@codecov
Copy link

codecov bot commented Dec 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.40%. Comparing base (5335004) to head (d7cf864).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   86.40%   86.40%   -0.01%     
==========================================
  Files          49       49              
  Lines        3862     3861       -1     
==========================================
- Hits         3337     3336       -1     
  Misses        525      525              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 merged commit 9ce358e into pyapp-kit:main Dec 27, 2025
28 of 29 checks passed
@tlambert03 tlambert03 deleted the fix-pyside6-test branch December 27, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Segfault in test_cmap_combo with pyside6 6.10

1 participant