#2358 passing tests

Author: Scottmar93

docs/source/parameters/parameter_sets.rst

@@ -99,4 +99,3 @@ Lithium-ion Parameter Sets
 ----------------------------
 {{ parameter_sets.get_docstring(k) }}
 {% endfor %}
-

tests/unit/test_parameters/test_ecm_parameters.py

@@ -7,11 +7,10 @@
 
 values = {
     "Initial SoC": 0.5,
-    "Initial cell temperature [degC]": 25,
-    "Initial jig temperature [degC]": 25,
+    "Initial temperature [K]": 25 + 273.15,
     "Cell capacity [A.h]": 100,
     "Nominal cell capacity [A.h]": 100,
-    "Ambient temperature [degC]": 25,
+    "Ambient temperature [K]": 25 + 273.15,
     "Current function [A]": 100,
     "Upper voltage cut-off [V]": 4.2,
     "Lower voltage cut-off [V]": 3.2,
@@ -49,15 +48,19 @@ def test_init_parameters(self):
             (param.current_with_time, "Current function [A]"),
             (param.dimensional_current_density_with_time, "Current function [A]"),
             (param.initial_soc, "Initial SoC"),
-            (param.initial_T_cell, "Initial cell temperature [degC]"),
-            (param.initial_T_jig, "Initial jig temperature [degC]"),
         ]
 
         for symbol, key in simpled_mapped_parameters:
             value = parameter_values.evaluate(symbol)
             expected_value = values[key]
             self.assertEqual(value, expected_value)
 
+        value = parameter_values.evaluate(param.initial_T_cell)
+        self.assertEqual(value, values["Initial temperature [K]"] - 273.15)
+
+        value = parameter_values.evaluate(param.initial_T_jig)
+        self.assertEqual(value, values["Initial temperature [K]"] - 273.15)
+
         compatibility_parameters = [
             (param.I_typ, 1),
             (param.n_electrodes_parallel, 1),
@@ -75,7 +78,6 @@ def test_function_parameters(self):
         sym = pybamm.Scalar(1)
 
         mapped_functions = [
-            (param.T_amb(sym), "Ambient temperature [degC]"),
             (param.ocv(sym), "Open circuit voltage [V]"),
             (param.rcr_element("R0 [Ohm]", sym, sym, sym), "R0 [Ohm]"),
             (param.rcr_element("R1 [Ohm]", sym, sym, sym), "R1 [Ohm]"),
@@ -89,6 +91,8 @@ def test_function_parameters(self):
             expected_value = values[key]
             self.assertEqual(value, expected_value)
 
+        value = parameter_values.evaluate(param.T_amb(sym))
+        self.assertEqual(value, values["Ambient temperature [K]"] - 273.15)
 
 if __name__ == "__main__":
     print("Add -v for more debug output")