-
-
Notifications
You must be signed in to change notification settings - Fork 713
Allow lists of input parameters as initial conditions #5191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5191 +/- ##
===========================================
+ Coverage 98.77% 98.79% +0.02%
===========================================
Files 321 321
Lines 27729 27707 -22
===========================================
- Hits 27389 27373 -16
+ Misses 340 334 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Does this still allow for the case where there is an |
Still works; going to edit this PR actually to make it a new feature that a list of input parameters can be provided and the inputs will be distributed correctly (useful for PyBoP). |
2106aca to
2d5ea7e
Compare
8d71eac to
6c889db
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
) * Fix typo in concentration description in notebook * Add CHANGELOG.md entry for typo fix * Remove unneccesary changelog entry Co-authored-by: Agriya Khetarpal <[email protected]> --------- Co-authored-by: Agriya Khetarpal <[email protected]>
main -> develop
martinjrobins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay on this @pipliggins. The rest of the tests look good, just those comments above
* fix `InputParameter` serialisation * Update CHANGELOG.md
…rialisation-fix Don't be too strict with func_args longer than symbol.children
…-team#5285) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* feat: add`silence_sundial_warnings` solver option * refactor: `silence_sundials_warnings` -> `silence_sundials_errors`
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Input parameters should not be able to be used as initial conditions (see #1261), but a bug was present where if more than one input parameter was provided but not all were used as initial conditions, the error warning could be bypassed.Allows input parameters used as initial conditions to be included within lists of inputs to the solver by converting model.y0 to model.y0_list, and calculating one initial state per input parameter set.
This rolls back a lot of the changes made by #4981 as the functionality is added to all the solvers; the
initial_conditionsargument added for IDAKLU has been removed in favour of allowing all inputs to be included withininputs.Fixes #5154
Fixes #5131