Skip to content

chore: use Lychee pre-commit hook#193

Draft
agriyakhetarpal wants to merge 10 commits intomainfrom
chore/lychee
Draft

chore: use Lychee pre-commit hook#193
agriyakhetarpal wants to merge 10 commits intomainfrom
chore/lychee

Conversation

@agriyakhetarpal
Copy link
Member

@agriyakhetarpal agriyakhetarpal commented Sep 9, 2024

CI time is not a concern for our website, so even if our linter takes thirty seconds instead of five, that should be fine

@netlify
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for pybamm-developer-preview ready!

Name Link
🔨 Latest commit 7d69fc7
🔍 Latest deploy log https://app.netlify.com/projects/pybamm-developer-preview/deploys/68dc3621f69d6e0008759149
😎 Deploy Preview https://deploy-preview-193--pybamm-developer-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99
Accessibility: 100
Best Practices: 92
SEO: 91
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@agriyakhetarpal
Copy link
Member Author

Strange, works fine locally

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agriyakhetarpal, it also doesn't show that for which specific link it is failing for. Is it something it'll show like previous workflow?

@agriyakhetarpal
Copy link
Member Author

Yes, it would show which link it would fail for, but it doesn't run with https://pre-commit.ci, so the links were not checked with this commit.

@agriyakhetarpal
Copy link
Member Author

agriyakhetarpal commented Sep 10, 2024

https://pre-commit.com/#rust

Looks like this is an issue worth reporting in lycheeverse/lychee upstream: it works with pre-commit locally and would do so with a GHA setup, but it doesn't work with https://pre-commit.ci. I'm not sure if I have the time to prepare a proper report and investigate right now. Would you like to do that, @arjxn-py?

@arjxn-py
Copy link
Member

arjxn-py commented Sep 10, 2024

https://pre-commit.com/#rust

Looks like this is an issue worth reporting in lycheeverse/lychee upstream: it works with pre-commit locally and would do so with a GHA setup, but it doesn't work with https://pre-commit.ci. I'm not sure if I have the time to prepare a proper report and investigate right now. Would you like to do that, @arjxn-py?

Sure @agriyakhetarpal, thanks for pinging. Would be happy to do that.

@agriyakhetarpal agriyakhetarpal marked this pull request as draft January 2, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants