Replace Twitter Link with LinkedIn and add LinkedIn icon to footer #330
Conversation
❌ Deploy Preview for pybamm-developer-preview failed.
|
|
The LinkedIn icon was added locally to the theme. Deployment failed because the icon commit isn't in the upstream Maintainers may need to add the LinkedIn icon to the theme first. |
|
Hi @ankitpokhrel08, thanks for experimenting with this! Could you explore adding the LinkedIn SVG to either the |
|
Created a pull request in the original submodule for the logo. @agriyakhetarpal |
|
Thanks for opening the PR upstream! Let's hope someone can get to it sometime soon. In the meantime, I figured out a way to make embeds work. How about we embed a specific post from the PyBaMM LinkedIn page? I think we can work with the following: <iframe src="https://www.linkedin.com/embed/feed/update/urn:li:share:7290208134936059904?collapsed=1" height="719" width="504" frameborder="0" allowfullscreen="" title="Embedded post"></iframe>which I got from this post: https://www.linkedin.com/posts/pybamm_tutorial-1-how-to-run-a-model-activity-7290208135712014336-5Jdy. Since it's about the first tutorial notebook, I think this is relevant enough to include. (with the title, the width and height values, etc., adjusted, of course) |
Added `linkedin.svg` icon. The PyBaMM organisation needed this icon, but it was not available. pybamm-team/pybamm.org#330 (comment)
❌ Deploy Preview for pybamm-developer-preview failed.
|
agriyakhetarpal
changed the title
|
unsure what the trouble with the submodule is; probably a caching thing? anyway, merging this. |
agriyakhetarpal
left a comment
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thanks, @ankitpokhrel08!
2 participants
As requested, the twitter link was replaced with the linkedIn and I have added some content as well.
#226
Before
After
I also added
linkedin.svglogo and added it to Footer as:Before
After
Responsive across devices
Re: LinkedIn oEmbed functionality
No, LinkedIn doesn't provide oEmbed functionality like Twitter does.