Add __qualname__ tests #5775
Draft
Add __qualname__ tests #5775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for function and method __qualname__ attributes. I believe these tests will fail with the current implementation but they should pass. These are tests for the correct behaviour of pybind#2059 and pybind#5774
|
@rwgk I'd agree, the - module_func
+ pybind11_detail_function_record_v1_system_libstdcpp_gxx_abi_1xxx_use_cxx11_abi_1.module_func |
Absolutely, I beat on this pretty hard already (4+ hours), but didn't get lucky: #5774 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests for function and method
__qualname__attributes.I believe these tests will fail with the current implementation but they should pass.
These are tests for the correct behaviour of #2059 and #5774
Suggested changelog entry: