Skip to content

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Aug 21, 2025

Description

Trying to fix issue seen in scikit-hep/iminuit#1100. Can't reproduce in our suite (tried in #5797), so going to try that with this PR. Edit: seems to pass correctly.

Suggested changelog entry:

  • Fix potential warning about number of threads being too large.

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii force-pushed the henryiii/fix/limitwarning branch from c8a4148 to 44a1070 Compare August 21, 2025 17:02
@henryiii henryiii marked this pull request as ready for review August 21, 2025 19:28
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@henryiii henryiii merged commit cddec2b into pybind:master Aug 21, 2025
128 of 131 checks passed
@henryiii henryiii deleted the henryiii/fix/limitwarning branch August 21, 2025 20:07
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Aug 21, 2025
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants