-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add float type caster and revert type hint changes to int_ and float_ #5839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
60e8528
Revert type hint changes to int_ and float_
gentlegiantJGC b8a619d
Fix tests
gentlegiantJGC 650c3ee
Add a custom py::float_ caster
gentlegiantJGC 4bab567
style: pre-commit fixes
pre-commit-ci[bot] 35948ce
Fix name
gentlegiantJGC a8a4d00
Fix variable
gentlegiantJGC 4b694ec
Try satisfying the formatter
gentlegiantJGC eaa18f1
Merge branch 'master' into fix-int-float-type-hint
gentlegiantJGC 53ca8a9
Rename test function
gentlegiantJGC 46e9e74
Simplify type caster
gentlegiantJGC 50e81a9
Fix reference counting issue
gentlegiantJGC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please rename this to
roundtrip_float
orfloat_roundtrip
or similar?(
cast
is super ambiguous in the context pybind11; C/C++ cast, to-Python, from-Python, all in the same name bucket unfortunately)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done