Avoid _PyObject_GetDictPtr() function #5868
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is also broken on free-threading because free-threading stores and reads dictionary pointer atomically, it is not safe to read the dictionary pointer directly as returned by this function. Use PyObject_ClearManagedDict() instead in clear_instance().
|
I marked my PR as a draft since I'm not sure that it's correct. And CIs do crash with segfault :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is also broken on free-threading because free-threading stores and reads dictionary pointer atomically, it is not safe to read the dictionary pointer directly as returned by this function.
Use PyObject_ClearManagedDict() instead in clear_instance().
Description
Suggested changelog entry: