Skip to content

Disable numeric supports type hinting - fixes issue #5767 #5875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Disable numeric supports type hinting - fixes issue #5767 #5875

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9a9a71b
Allow SupportsInt and SupportsFloat argument typing to be disabled
daltairwalter Oct 15, 2025
329271c
Merge remote-tracking branch 'origin/master' into DisableNumericSupports
daltairwalter Oct 15, 2025
d30f8f0
Merge remote-tracking branch 'origin/master' into DisableNumericSupports
daltairwalter Oct 17, 2025
a81ec40
fix formatting that was accidentally lost
daltairwalter Oct 17, 2025
ccda846
rename macros names to include TYPE_HINT
daltairwalter Oct 18, 2025
aa56278
add define to ci.yml file for testing
daltairwalter Oct 18, 2025
a27b954
Add =1 to make cmake happy: -DPYBIND11_DISABLE_SUPPORTS_TYPE_HINTS=1
rwgk Oct 19, 2025
97e3ee8
Merge branch 'master' into daltairwalter→DisableNumericSupports
rwgk Oct 19, 2025
a7dad4c
Pass "-DPYBIND11_DISABLE_SUPPORTS_TYPE_HINTS" via -DCMAKE_CXX_FLAGS
rwgk Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions include/pybind11/cast.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,8 +348,10 @@ struct type_caster<T, enable_if_t<std::is_arithmetic<T>::value && !is_std_char_t
}

PYBIND11_TYPE_CASTER(T,
io_name<std::is_integral<T>::value>(
"typing.SupportsInt", "int", "typing.SupportsFloat", "float"));
io_name<std::is_integral<T>::value>(PYBIND11_TYPE_ARGUMENT_INT,
"int",
PYBIND11_TYPE_ARGUMENT_FLOAT,
"float"));
};

template <typename T>
Expand Down
8 changes: 8 additions & 0 deletions include/pybind11/detail/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,14 @@
# define PYBIND11_TYPE_GUARD_TYPE_HINT "typing_extensions.TypeGuard"
#endif

#ifndef PYBIND11_DISABLE_NUMERIC_SUPPORTS_HINT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming suggestions:

PYBIND11_DISABLE_SUPPORTS_TYPE_HINTS
PYBIND11_ARG_TYPE_HINT_FLOAT
PYBIND11_ARG_TYPE_HINT_INT

(the main idea is to consistently have "type hint" in all macros)

Note sure about PYBIND11_DISABLE_NUMERIC_SUPPORTS_TYPE_HINTS, or PYBIND11_DISABLE_ARITHMETIC_SUPPORTS_TYPE_HINTS, or similar. Do we want "numeric" or "arithmetic" in name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, I looked at the other type hint macros and they all end in TYPE_HINT, and this seemed like a nice pattern.

PYBIND11_DISABLE_SUPPORTS_TYPE_HINTS
PYBIND11_FLOAT_ARGUMENT_TYPE_HINT
PYBIND11_INT_ARGUMENT_TYPE_HINT

I will test my changes, make the ci.yml change and submit again.

# define PYBIND11_TYPE_ARGUMENT_FLOAT "typing.SupportsFloat"
# define PYBIND11_TYPE_ARGUMENT_INT "typing.SupportsInt"
#else
# define PYBIND11_TYPE_ARGUMENT_FLOAT "float"
# define PYBIND11_TYPE_ARGUMENT_INT "int"
#endif

// #define PYBIND11_STR_LEGACY_PERMISSIVE
// If DEFINED, pybind11::str can hold PyUnicodeObject or PyBytesObject
// (probably surprising and never documented, but this was the
Expand Down
Loading