-
Notifications
You must be signed in to change notification settings - Fork 47
Create parent Result class #860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #860 +/- ##
===========================================
+ Coverage 89.41% 90.73% +1.31%
===========================================
Files 63 67 +4
Lines 4857 5214 +357
===========================================
+ Hits 4343 4731 +388
+ Misses 514 483 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SarahRo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good to me and makes the code cleaner.
There is just one minor thing: I find it somewhat confusing where in the code the subclasses of Result are defined. OptimisationResult is defined in base_optimiser.py, but SamplingResult in mcmc_summary. Would it maybe make sense to define them in their own file?
Description
Create a parent class for all types of optimisation and sampling result to clarify which attributes are shared.
Also, move
PosteriorSummaryattributes to theSamplingResultand deprecate thepints.AdaptiveCovarianceMCMCsampler.Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).
Important checks:
Please confirm the following before marking the PR as ready for review:
$ pre-commit runor$ nox -s pre-commit(see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)nox -s testsnox -s doctest