Skip to content

Conversation

@SarahRo
Copy link
Contributor

@SarahRo SarahRo commented Jan 6, 2026

Description

Introduce MultivariateParameter (subclass of pybop.Parameter) instead of MultivariateParameters (subclass of pybop.Parameters)

Fixes #856

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: $ pre-commit run or $ nox -s pre-commit (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctest
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.73%. Comparing base (4628a65) to head (3b196b5).
⚠️ Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
pybop/parameters/parameter.py 97.77% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #862      +/-   ##
===========================================
+ Coverage    89.41%   90.73%   +1.31%     
===========================================
  Files           63       66       +3     
  Lines         4857     5224     +367     
===========================================
+ Hits          4343     4740     +397     
+ Misses         514      484      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow MultivariateParameters to be set within ParameterValues

2 participants