lib/tiam1808: split SPIPinControl() into two functions

Split SPIPinControl() into SPIPinControlGet() and SPIPinControlSet()
functions. Having to pass a pointer to flags to set a value was awkward
and the read/write flag parameter made it difficult to know if we were
reading or writing. And any function that does two completely different
things based on a boolean flag is a code smell.

Author: dlech

lib/pbio/drv/block_device/block_device_ev3.c

@@ -192,8 +192,7 @@ static void spi_bus_init(void) {
     SPIReset(SOC_SPI_0_REGS);
     SPIOutOfReset(SOC_SPI_0_REGS);
     SPIModeConfigure(SOC_SPI_0_REGS, SPI_MASTER_MODE);
-    unsigned int spipc0 = SPI_SPIPC0_SOMIFUN | SPI_SPIPC0_SIMOFUN | SPI_SPIPC0_CLKFUN | SPI_SPIPC0_SCS0FUN0 | SPI_SPIPC0_SCS0FUN3;
-    SPIPinControl(SOC_SPI_0_REGS, 0, 0, &spipc0);
+    SPIPinControlSet(SOC_SPI_0_REGS, 0, SPI_SPIPC0_SOMIFUN | SPI_SPIPC0_SIMOFUN | SPI_SPIPC0_CLKFUN | SPI_SPIPC0_SCS0FUN0 | SPI_SPIPC0_SCS0FUN3);
     SPIDefaultCSSet(SOC_SPI_0_REGS, (1 << PBDRV_EV3_SPI0_FLASH_CS) | (1 << PBDRV_EV3_SPI0_ADC_CS));
 
     // SPI module data formats

lib/pbio/drv/display/display_ev3.c

@@ -429,9 +429,8 @@ static void pbdrv_display_ev3_spi_init(void) {
     SPIOutOfReset(SOC_SPI_1_REGS);
 
     // Mode.
-    uint32_t spipc0 = SPI_SPIPC0_SOMIFUN | SPI_SPIPC0_SIMOFUN | SPI_SPIPC0_CLKFUN | SPI_SPIPC0_ENAFUN;
     SPIModeConfigure(SOC_SPI_1_REGS, SPI_MASTER_MODE);
-    SPIPinControl(SOC_SPI_1_REGS, 0, 0, (unsigned int *)&spipc0);
+    SPIPinControlSet(SOC_SPI_1_REGS, 0, SPI_SPIPC0_SOMIFUN | SPI_SPIPC0_SIMOFUN | SPI_SPIPC0_CLKFUN | SPI_SPIPC0_ENAFUN);
 
     // Config.
     SPIClkConfigure(SOC_SPI_1_REGS, SOC_SYSCLK_2_FREQ, 10000000, SPI_DATA_FORMAT0);

lib/tiam1808/drivers/spi.c

@@ -110,32 +110,37 @@ void SPIModeConfigure(unsigned int baseAdd, unsigned int flag)
 }
 
 /**
-* \brief - Configures SPI Pin Control Registers.\n
+* \brief - Get SPI Pin Control Register value.\n
 *
 * \param - baseAdd is the Memory Address of the SPI instance used.\n
 * \param - idx     is the Pin Control register number.It can take
 *                  any integer value between 0 and 5.\n
 *
-* \param - flag    is to indicate to whether to (1)read from Pin Control
-*                  Register or to (0)write to Pin Control Register.\n
+* \param - val     the value read
 *
-* \param - val     is a value/return argument which has the value to be written
-*                  in case of writes or the value read in case of reads
+* \return none.\n
+**/
+void SPIPinControlGet(unsigned int baseAdd, unsigned int idx, unsigned int *val)
+{
+    *val = HWREG(baseAdd + SPI_SPIPC(idx));
+}
+
+/**
+* \brief - Set SPI Pin Control Register value.\n
+*
+* \param - baseAdd is the Memory Address of the SPI instance used.\n
+* \param - idx     is the Pin Control register number.It can take
+*                  any integer value between 0 and 5.\n
+*
+* \param - val     the value to be written
 *
 * \return none.\n
 **/
-void SPIPinControl(unsigned int baseAdd, unsigned int idx,
-                           unsigned int flag, unsigned int *val)
+void SPIPinControlSet(unsigned int baseAdd, unsigned int idx, unsigned int val)
 {
-    if (0 == flag)
-    {
-        HWREG(baseAdd + SPI_SPIPC(idx)) = *val;
-    }
-    else
-    {
-        *val = HWREG(baseAdd + SPI_SPIPC(idx));
-    }
+    HWREG(baseAdd + SPI_SPIPC(idx)) = val;
 }
+
 /**
 * \brief - Configures SPI CS and ENA Delay in SPIDELAY Register.\n
 *

lib/tiam1808/tiam1808/spi.h

@@ -204,8 +204,8 @@ void SPIOutOfReset(unsigned int baseAdd);
 
 void SPIModeConfigure(unsigned int baseAdd, unsigned int flag);
 
-void SPIPinControl(unsigned int baseAdd, unsigned int idx,
-                   unsigned int flag, unsigned int *val);
+void SPIPinControlGet(unsigned int baseAdd, unsigned int idx, unsigned int *val);
+void SPIPinControlSet(unsigned int baseAdd, unsigned int idx, unsigned int val);
 
 void SPIDelayConfigure(unsigned int baseAdd, unsigned int c2edelay,
                        unsigned int t2edelay, unsigned int t2cdelay,