pbio/sys/status: Rename pbio_pybricks_status_t.

The status used to be just flags, but contains other statuses too now. Rename
the flag part to pbio_pybricks_status_flags_t to make this a bit clearer.

Author: laurensvalk

lib/pbio/include/pbio/protocol.h

@@ -235,7 +235,7 @@ typedef enum {
      * Status report event.
      *
      * The payload is one 32-bit little-endian unsigned integer containing
-     * ::pbio_pybricks_status_t flags and a one byte program identifier
+     * ::pbio_pybricks_status_flags_t flags and a one byte program identifier
      * representing the currently active program if it is running.
      *
      * @since Pybricks Profile v1.0.0. Program identifier added in Pybricks Profile v1.4.0.
@@ -331,12 +331,12 @@ typedef enum {
     PBIO_PYBRICKS_STATUS_BLE_HOST_CONNECTED = 9,
     /** Total number of indications. */
     NUM_PBIO_PYBRICKS_STATUS,
-} pbio_pybricks_status_t;
+} pbio_pybricks_status_flags_t;
 
 /**
  * Converts a status value to a bit flag.
  *
- * @param [in]  status  A ::pbio_pybricks_status_t value.
+ * @param [in]  status  A ::pbio_pybricks_status_flags_t value.
  * @return              A bit flag corresponding to @p status.
  */
 #define PBIO_PYBRICKS_STATUS_FLAG(status) (1 << status)

lib/pbio/include/pbsys/status.h

@@ -17,10 +17,10 @@
 #define PBSYS_STATUS_REPORT_SIZE 7
 
 void pbsys_status_set_program_id(pbio_pybricks_user_program_id_t program_id);
-void pbsys_status_set(pbio_pybricks_status_t status);
-void pbsys_status_clear(pbio_pybricks_status_t status);
-bool pbsys_status_test(pbio_pybricks_status_t status);
-bool pbsys_status_test_debounce(pbio_pybricks_status_t status, bool state, uint32_t ms);
+void pbsys_status_set(pbio_pybricks_status_flags_t status);
+void pbsys_status_clear(pbio_pybricks_status_flags_t status);
+bool pbsys_status_test(pbio_pybricks_status_flags_t status);
+bool pbsys_status_test_debounce(pbio_pybricks_status_flags_t status, bool state, uint32_t ms);
 uint32_t pbsys_status_get_flags(void);
 uint32_t pbsys_status_get_status_report(uint8_t *buf);
 void pbsys_status_increment_selected_slot(bool increment);

lib/pbio/sys/status.c

@@ -28,7 +28,7 @@ static struct {
     pbio_pybricks_user_program_id_t slot;
 } pbsys_status;
 
-static void pbsys_status_update_flag(pbio_pybricks_status_t status, bool set) {
+static void pbsys_status_update_flag(pbio_pybricks_status_flags_t status, bool set) {
     uint32_t new_flags = set ? pbsys_status.flags | PBIO_PYBRICKS_STATUS_FLAG(status) : pbsys_status.flags & ~PBIO_PYBRICKS_STATUS_FLAG(status);
 
     if (pbsys_status.flags == new_flags) {
@@ -112,7 +112,7 @@ void pbsys_status_set_program_id(pbio_pybricks_user_program_id_t program_id) {
  * Sets a system status status indication.
  * @param [in]  status   The status indication to set.
  */
-void pbsys_status_set(pbio_pybricks_status_t status) {
+void pbsys_status_set(pbio_pybricks_status_flags_t status) {
     assert(status < NUM_PBIO_PYBRICKS_STATUS);
     pbsys_status_update_flag(status, true);
 }
@@ -121,7 +121,7 @@ void pbsys_status_set(pbio_pybricks_status_t status) {
  * Clears a system status status indication.
  * @param [in]  status   The status indication to clear.
  */
-void pbsys_status_clear(pbio_pybricks_status_t status) {
+void pbsys_status_clear(pbio_pybricks_status_flags_t status) {
     assert(status < NUM_PBIO_PYBRICKS_STATUS);
     pbsys_status_update_flag(status, false);
 }
@@ -131,7 +131,7 @@ void pbsys_status_clear(pbio_pybricks_status_t status) {
  * @param [in]  status  The status indication  to to test.
  * @return              *true* if @p status is set, otherwise *false*.
  */
-bool pbsys_status_test(pbio_pybricks_status_t status) {
+bool pbsys_status_test(pbio_pybricks_status_flags_t status) {
     assert(status < NUM_PBIO_PYBRICKS_STATUS);
     return !!(pbsys_status.flags & PBIO_PYBRICKS_STATUS_FLAG(status));
 }
@@ -148,7 +148,7 @@ bool pbsys_status_test(pbio_pybricks_status_t status) {
  * @return              *true* if @p status has been set to @p state for at
  *                      least @p ms, otherwise *false*.
  */
-bool pbsys_status_test_debounce(pbio_pybricks_status_t status, bool state, uint32_t ms) {
+bool pbsys_status_test_debounce(pbio_pybricks_status_flags_t status, bool state, uint32_t ms) {
     assert(status < NUM_PBIO_PYBRICKS_STATUS);
     if (pbsys_status_test(status) != state) {
         return false;

lib/pbio/test/sys/test_status.c

@@ -36,7 +36,7 @@ static PT_THREAD(test_status(struct pt *pt)) {
     process_start(&status_test_process);
 
     // use the last valid flag for edge case
-    static const pbio_pybricks_status_t test_flag = NUM_PBIO_PYBRICKS_STATUS - 1;
+    static const pbio_pybricks_status_flags_t test_flag = NUM_PBIO_PYBRICKS_STATUS - 1;
 
     // ensure flags are initialized as unset
     tt_want(!pbsys_status_test(test_flag));