Skip to content

Commit fb763ac

Browse files
committed
npm/firmware: make new metadata optional
Making the new metadata fields not optional was a breaking change.
1 parent d2c1afb commit fb763ac

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

npm/firmware/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
## Unreleased
33
### Changed
44
- Dropped fallback to default name in `encodeHubName()` on empty string.
5+
- Use Typescript optional syntax in `FirmwareMetadata` instead of `| undefined`.
56

67
## 4.13.0-rc.1 - 2021-11-19
78
### Added

npm/firmware/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,11 @@ export interface FirmwareMetadata {
6363
/** The maximum firmware size allowed on the hub. */
6464
'max-firmware-size': number;
6565
/** The offset to where the hub name is stored in the firmware. (since v1.1.0) */
66-
'hub-name-offset': number | undefined;
66+
'hub-name-offset'?: number;
6767
/** The maximum size of the firmware name in bytes, including the zero-termination. (since v1.1.0) */
68-
'max-hub-name-size': number | undefined;
68+
'max-hub-name-size'?: number;
6969
/** The SHA256 hash of the firmware. (since v1.1.0) */
70-
'firmware-sha256': string | undefined;
70+
'firmware-sha256'?: string;
7171
}
7272

7373
/** Types of errors that can be raised by FirmwareReader. */

0 commit comments

Comments
 (0)