EV3 linker cleanup #317
Merged
EV3 linker cleanup #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This source file for startup.o is empty, so this does nothing. Also, in this script, we use ENTRY() to determine the entry point, so we don't need to do anything special for the first section in RAM.
We already have a .noinit section, so we can drop all of the other named NOLOAD sections and just use that one.
The start.S script is already reserving 2.8M for the stack via:
.set UND_STACK_SIZE, 0x50000
.set ABT_STACK_SIZE, 0x50000
.set FIQ_STACK_SIZE, 0xF0000
.set IRQ_STACK_SIZE, 0xF0000
.set SVC_STACK_SIZE, 0x50000
And expects a bit more for the main stack. 64K was not nearly enough
to cover this. 4M should be more than enough.
This file is empty because we need a .S file for startup on EV3 instead of a .s file. So we can add a conditional to the makefile to to not compile this file on the EV3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little 🧹