[EV3] Implement the rest of the clock API #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note that I've tested that I haven't broken |
laurensvalk
reviewed
Jul 14, 2025
laurensvalk
reviewed
Jul 14, 2025
laurensvalk
reviewed
Jul 14, 2025
laurensvalk
reviewed
Jul 14, 2025
dlech
reviewed
Jul 15, 2025
The interrupt enable and interrupt status bits are not the same. There is no need to disable and re-enable the interrupt if clearing the correct bit.
Because the time period never changes, there is no reason to use reload
The PRU1 code which will be added in the future expects the 34 part of Timer0 to count with a period which is a multiple of 256*256 in order to generate accurate PWM widths. We switch the system tick in order to not conflict with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the rest of the clock API. It currently assumes that IRQs are never disabled on the EV3.
Closes pybricks/support#2270