Remove support for busy-wait millisecond delays with IRQs disabled #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArcaneNibble
force-pushed
the
clock-cleanup
branch
from
2b5e210 to
1ebec60
Compare
Collaborator
Author
|
Hrm, looks like NXT still has blocking delays in its bootup process. Going to keep those in place for now and only remove the mphalport.c support for running with IRQs disabled. |
The current implementation of Pybricks does not disable IRQs for any significant length of time, which means that we can remove clock driver code supporting it.
ArcaneNibble
force-pushed
the
clock-cleanup
branch
from
1ebec60 to
4819a79
Compare
Member
|
Nice one, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of Pybricks does not disable IRQs for any significant length of time, which means that we can remove clock driver code supporting it.
The STM32 code still supports microsecond delays.